Prefer switch statements in PHP
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
Install this rule for wispbit
Add this rule to wispbit and it will run when you open a pull request
Install this rule for Coderabbit
Copy the configuration below and add it to your repository as .coderabbit.yml
in your project root.
reviews:
path_instructions:
- path: "*.php"
instructions: |
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
Install this rule for Greptile
Greptile rules can be added through the web interface. Please see this documentation for details on how to add custom rules and context.
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
File Path Patterns:
Install this rule for GitHub Copilot
Copilot instructions can be added through the interface. See the documentation for details on how to create coding guidelines.
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
File Path Patterns:
Install this rule for Graphite Diamond
Diamond custom rules can be added through the interface. See the documentation for details on how to create custom rules.
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
File Path Patterns:
Use with Cline
Copy the rule below and ask Cline to review your code using this rule
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
Use with OpenAI Codex
Copy the rule below and ask OpenAI Codex to review your code using this rule
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
Use with Cursor
Copy the rule below and ask Cursor to review your code using this rule
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
Use with Claude Code
Copy the rule below and ask Claude Code to review your code using this rule
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```
Install this rule for Windsurf
To set up rules for Windsurf Reviews, please see this documentation
Use switch statements when handling multiple attribute types.
Bad:
```php
foreach ($attributes as $attribute) {
if ($attribute->getAttribute('type') === Database::VAR_RELATIONSHIP) {
// Handle relationship attribute
}
if ($attribute->getAttribute('type') === Database::VAR_STRING) {
// Handle string attribute
}
}
```
Good:
```php
foreach ($attributes as $attribute) {
$attributeType = $attribute->getAttribute('type');
switch ($attributeType) {
case Database::VAR_RELATIONSHIP:
// Handle relationship attribute
break;
case Database::VAR_STRING:
// Handle string attribute
break;
}
}
```